Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 21 Dec 2023 13:23:14 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 08/17] writeback: Factor should_writeback_folio() out of write_cache_pages() |
| |
On Thu, Dec 21, 2023 at 12:22:06PM +0100, Jan Kara wrote: > > +static bool should_writeback_folio(struct address_space *mapping, > > + struct writeback_control *wbc, struct folio *folio) > > +{ > > I'd call this function folio_prepare_writeback() or something like that to > make it clearer that this function is not only about the decision whether > we want to write folio or not but we also clear the dirty bit & > writeprotect the folio in page tables.
Fine with me. I'll wait for willy to chime in if he has a strong preference.
| ![\](/images/icornerr.gif) |