lkml.org 
[lkml]   [2023]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08/17] writeback: Factor should_writeback_folio() out of write_cache_pages()
    On Mon 18-12-23 16:35:44, Christoph Hellwig wrote:
    > From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
    >
    > Reduce write_cache_pages() by about 30 lines; much of it is commentary,
    > but it all bundles nicely into an obvious function.
    >
    > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
    > Signed-off-by: Christoph Hellwig <hch@lst.de>

    One nit below, otherwise feel free to add:

    Reviewed-by: Jan Kara <jack@suse.cz>

    > +static bool should_writeback_folio(struct address_space *mapping,
    > + struct writeback_control *wbc, struct folio *folio)
    > +{

    I'd call this function folio_prepare_writeback() or something like that to
    make it clearer that this function is not only about the decision whether
    we want to write folio or not but we also clear the dirty bit &
    writeprotect the folio in page tables.

    Honza
    --
    Jan Kara <jack@suse.com>
    SUSE Labs, CR

    \
     
     \ /
      Last update: 2023-12-21 12:23    [W:2.548 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site