Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 21 Dec 2023 10:22:39 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net v2 2/2] net: phylink: Add module_exit_stub() |
| |
On Thu, Dec 21, 2023 at 04:51:09PM +0800, Gan, Yi Fang wrote: > In delete_module(), if mod->init callback is defined but mod->exit > callback is not defined, it will assume the module cannot be removed > and return EBUSY. The module_exit() is missing from current phylink > module drive causing failure while unloading it.
You are missing justification it is actually safe to remove phylink. Maybe Russell King deliberately did not implement module_exit() because it can explode in interesting ways if it was?
Andrew
| ![\](/images/icornerr.gif) |