Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 21 Dec 2023 10:11:04 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH net v2 0/2] Fix phylink unloadable issue |
| |
On Thu, Dec 21, 2023 at 04:51:07PM +0800, Gan, Yi Fang wrote: > Add module_exit_stub() for phylink module. > > Changes since v1: > - Introduce a helper macro for module_exit() boilerplate > > This series is the combination of following: > v1 with empty phylink_exit(): > https://lore.kernel.org/all/20231127101603.807593-1-yi.fang.gan@intel.com/ > v1 of module_exit_stub(): > https://lore.kernel.org/all/20231212094352.2263283-1-yi.fang.gan@intel.com/
As I said before, no, this isn't ok. Why just resubmit a patch when it's already been rejected?
This patch series should NOT be accepted as-is, you know this!
Also, you are not following the documented and REQUIRED rules for Intel developers to be submitting kernel patches, so on that reason alone these need to be rejected.
Please work with the Intel internel developers to do this correctly if you wish to submit this again in the future.
greg k-h
| ![\](/images/icornerr.gif) |