Messages in this thread | | | Date | Fri, 15 Dec 2023 12:38:03 +0000 | Subject | Re: [PATCH v2 10/10] clk: qcom: Add camcc clock driver for x1e80100 | From | Bryan O'Donoghue <> |
| |
On 14/12/2023 16:49, Abel Vesa wrote: > From: Rajendra Nayak <quic_rjendra@quicinc.com> > > Add the camcc clock driver for x1e80100 > > Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> --- .name = "cam_cc-x1e80100",
This is some very akward naming here.
"camcc-x1e80100"
Same comment with the defines not "CAM_CC_THING" just "CAMCC_THING"
With those two nits fixed.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> + .of_match_table = cam_cc_x1e80100_match_table, > + }, > +}; > + > +module_platform_driver(cam_cc_x1e80100_driver); > + > +MODULE_DESCRIPTION("QTI CAM_CC x1e80100 Driver");
Again with the "CAM_CC" this should be -> "QTI Camera Clock Controller"
--- bod
| |