Messages in this thread | | | Date | Thu, 9 Nov 2023 14:48:04 +0100 | From | Johan Hovold <> | Subject | Re: [PATCH] soc: qcom: pmic_glink_altmode: fix port sanity check |
| |
On Thu, Nov 09, 2023 at 02:28:59PM +0100, Konrad Dybcio wrote: > On 11/9/23 10:31, Johan Hovold wrote:
> > - if (!altmode->ports[port].altmode) { > > + if (port >= ARRAY_SIZE(altmode->ports) || !altmode->ports[port].altmode) {
> I'd personally use PMIC_GLINK_MAX_PORTS directly but it's the same
That's what I'd generally do as well, but here I followed the style of this driver (and using ARRAY_SIZE() is arguable more safe).
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Thanks for reviewing.
Johan
| |