Messages in this thread | | | Date | Thu, 9 Nov 2023 14:28:59 +0100 | Subject | Re: [PATCH] soc: qcom: pmic_glink_altmode: fix port sanity check | From | Konrad Dybcio <> |
| |
On 11/9/23 10:31, Johan Hovold wrote: > The PMIC GLINK altmode driver currently supports at most two ports. > > Fix the incomplete port sanity check on notifications to avoid > accessing and corrupting memory beyond the port array if we ever get a > notification for an unsupported port. > > Fixes: 080b4e24852b ("soc: qcom: pmic_glink: Introduce altmode support") > Cc: stable@vger.kernel.org # 6.3 > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/soc/qcom/pmic_glink_altmode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/qcom/pmic_glink_altmode.c b/drivers/soc/qcom/pmic_glink_altmode.c > index 974c14d1e0bf..561d6ba005f4 100644 > --- a/drivers/soc/qcom/pmic_glink_altmode.c > +++ b/drivers/soc/qcom/pmic_glink_altmode.c > @@ -285,7 +285,7 @@ static void pmic_glink_altmode_sc8180xp_notify(struct pmic_glink_altmode *altmod > > svid = mux == 2 ? USB_TYPEC_DP_SID : 0; > > - if (!altmode->ports[port].altmode) { > + if (port >= ARRAY_SIZE(altmode->ports) || !altmode->ports[port].altmode) { I'd personally use PMIC_GLINK_MAX_PORTS directly but it's the same
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
| |