Messages in this thread | | | Date | Wed, 8 Nov 2023 17:19:37 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH net v3 4/4] net: ethernet: cortina: Checksum only TCP and UDP |
| |
On Tue, Nov 07, 2023 at 10:54:29AM +0100, Linus Walleij wrote: > It is a bit odd that frames that are neither TCP or UDP > (such as ICMP or ARP) are still sent to the checksumming > engine, where they are clearly just ignored. > > Rewrite the logic slightly so that we first check if the > frame is TCP or UDP, in that case bypass the checksum > engine. > > Reported-by: Vladimir Oltean <olteanv@gmail.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > ---
If this patch doesn't fix anything and isn't a dependency for anything, it shouldn't be present in a series targeted for "net". And anyway, I think it's not needed in general after the discussion on v2.
| |