Messages in this thread | | | Date | Wed, 8 Nov 2023 17:29:36 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH net v3 1/4] net: ethernet: cortina: Fix MTU max setting |
| |
On Wed, Nov 08, 2023 at 03:37:28PM +0100, Linus Walleij wrote: > On Wed, Nov 8, 2023 at 3:26 PM Vladimir Oltean <olteanv@gmail.com> wrote: > > On Tue, Nov 07, 2023 at 10:54:26AM +0100, Linus Walleij wrote: > > > > The RX max frame size is over 10000 for the Gemini ethernet, > > > but the TX max frame size is actually just 2047 (0x7ff after > > > checking the datasheet). Reflect this in what we offer to Linux, > > > cap the MTU at the TX max frame minus ethernet headers. > > > > > > Use the BIT() macro for related bit flags so these TX settings > > > are consistent. > > > > What does this second paragraph intend to say? The patch doesn't use the > > BIT() macro. > > Ah it's a leftover from v1 where I did some unrelated cleanup using > BIT() but Andrew remarked on it so I dropped it. > > Maybe this twoliner in the commit message can be deleted when > applying?
I think it's better if you do it, there are some more minor fixups which you could bundle up with a new series.
| |