lkml.org 
[lkml]   [2023]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 09/21] binder: split up binder_update_page_range()
From
Carlos Llamas <cmllamas@google.com> writes:
> The binder_update_page_range() function performs both allocation and
> freeing of binder pages. However, these two operations are unrelated and
> have no common logic. In fact, when a free operation is requested, the
> allocation logic is skipped entirely. This behavior makes the error path
> unnecessarily complex. To improve readability of the code, this patch
> splits the allocation and freeing operations into separate functions.
>
> No functional changes are introduced by this patch.
>
> Signed-off-by: Carlos Llamas <cmllamas@google.com>

The part below err_vm_insert_page_failed was a bit tricky, but I agree
that this is correct.

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

\
 
 \ /
  Last update: 2023-11-20 13:51    [W:0.546 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site