| Date | Tue, 7 Nov 2023 09:08:15 +0000 | Subject | Re: [PATCH 09/21] binder: split up binder_update_page_range() | From | Alice Ryhl <> |
| |
Carlos Llamas <cmllamas@google.com> writes: > The binder_update_page_range() function performs both allocation and > freeing of binder pages. However, these two operations are unrelated and > have no common logic. In fact, when a free operation is requested, the > allocation logic is skipped entirely. This behavior makes the error path > unnecessarily complex. To improve readability of the code, this patch > splits the allocation and freeing operations into separate functions. > > No functional changes are introduced by this patch. > > Signed-off-by: Carlos Llamas <cmllamas@google.com>
The part below err_vm_insert_page_failed was a bit tricky, but I agree that this is correct.
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
|