lkml.org 
[lkml]   [2023]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH 01/21] binder: use EPOLLERR from eventpoll.h
    From
    Use EPOLLERR instead of POLLERR to make sure it is cast to the correct
    __poll_t type. This fixes the following sparse issue:

    drivers/android/binder.c:5030:24: warning: incorrect type in return expression (different base types)
    drivers/android/binder.c:5030:24: expected restricted __poll_t
    drivers/android/binder.c:5030:24: got int

    Fixes: f88982679f54 ("binder: check for binder_thread allocation failure in binder_poll()")
    Cc: stable@vger.kernel.org
    Cc: Eric Biggers <ebiggers@google.com>
    Signed-off-by: Carlos Llamas <cmllamas@google.com>
    ---
    drivers/android/binder.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/android/binder.c b/drivers/android/binder.c
    index 92128aae2d06..71a40a4c546f 100644
    --- a/drivers/android/binder.c
    +++ b/drivers/android/binder.c
    @@ -5030,7 +5030,7 @@ static __poll_t binder_poll(struct file *filp,

    thread = binder_get_thread(proc);
    if (!thread)
    - return POLLERR;
    + return EPOLLERR;

    binder_inner_proc_lock(thread->proc);
    thread->looper |= BINDER_LOOPER_STATE_POLL;
    --
    2.42.0.869.gea05f2083d-goog
    \
     
     \ /
      Last update: 2023-11-02 20:04    [W:5.575 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site