lkml.org 
[lkml]   [2023]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 68/86] treewide: mm: remove cond_resched()
On (23/11/07 15:08), Ankur Arora wrote:
[..]
> +++ b/mm/zsmalloc.c
> @@ -2029,7 +2029,6 @@ static unsigned long __zs_compact(struct zs_pool *pool,
> dst_zspage = NULL;
>
> spin_unlock(&pool->lock);
> - cond_resched();
> spin_lock(&pool->lock);
> }
> }

I'd personally prefer to have a comment explaining why we do that
spin_unlock/spin_lock sequence, which may look confusing to people.

Maybe would make sense to put a nice comment in all similar cases.
For instance:

rcu_read_unlock();
- cond_resched();
rcu_read_lock();

\
 
 \ /
  Last update: 2023-11-20 13:52    [W:0.821 / U:1.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site