Messages in this thread | | | Date | Wed, 8 Nov 2023 10:08:18 -0500 | From | Steven Rostedt <> | Subject | Re: [RFC PATCH 71/86] treewide: lib: remove cond_resched() |
| |
On Wed, 8 Nov 2023 17:15:11 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
> > lib/crc32test.c | 2 -- > > lib/crypto/mpi/mpi-pow.c | 1 - > > lib/memcpy_kunit.c | 5 ----- > > lib/random32.c | 1 - > > lib/rhashtable.c | 2 -- > > lib/test_bpf.c | 3 --- > > lib/test_lockup.c | 2 +- > > lib/test_maple_tree.c | 8 -------- > > lib/test_rhashtable.c | 10 ---------- > > 9 files changed, 1 insertion(+), 33 deletions(-) > > Nack.
A "Nack" with no commentary is completely useless and borderline offensive.
What is your rationale for the Nack?
The cond_resched() is going away if the patches earlier in the series gets implemented. So either it is removed from your code, or it will become a nop, and just wasting bits in the source tree. Your choice.
-- Steve
| |