Messages in this thread Patch in this message | | | Date | Fri, 3 Nov 2023 23:57:52 +0000 | From | Jules Irenge <> | Subject | [PATCH 3/3] perf/x86/amd:Convert snprintf() to sysfs_emit() |
| |
Coccinelle reports a warning WARNING: use scnprintf or sprintf
Following the advice on kernel documentation https://www.kernel.org/doc/html/latest/filesystems/sysfs.html
For show(device *...) functions, only use sysfs_emit() or sysfs_emit_at() especially when formatting the value to be returned to user space. Convert snprintf() to sysfs_emit()
Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- arch/x86/events/amd/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c index e24976593a29..f2fef75d464c 100644 --- a/arch/x86/events/amd/core.c +++ b/arch/x86/events/amd/core.c @@ -1279,7 +1279,7 @@ static ssize_t branches_show(struct device *cdev, struct device_attribute *attr, char *buf) { - return snprintf(buf, PAGE_SIZE, "%d\n", x86_pmu.lbr_nr); + return sysfs_emit(buf, "%d\n", x86_pmu.lbr_nr); } static DEVICE_ATTR_RO(branches); -- 2.41.0
| |