Messages in this thread | | | From | Doug Anderson <> | Date | Fri, 3 Nov 2023 09:02:55 -0700 | Subject | Re: [PATCH v2 4/4] drm/panel-edp: Choose correct preferred mode |
| |
Hi,
On Thu, Nov 2, 2023 at 3:13 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > If a non generic edp-panel is under aux-bus, the mode read from edid would > still be selected as preferred and results in multiple preferred modes, > which is ambiguous. > > If a hard-coded mode is present, unset the preferred bit of the modes read > from edid. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > v1->v2: split patches from drm_modes. > --- > drivers/gpu/drm/panel/panel-edp.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Do you think this should have a "Fixes?" As per discussion on V1 [1], this has probably been a bit broken from the beginning, though I guess it only became a big deal after the AUX bus made it so that the panel driver commonly had the EDID...
[1] https://lore.kernel.org/r/CAD=FV=WHzCdiYumsxUm_am+ALqq9SOOrjf=JYHqJuiKFB+Dnsw@mail.gmail.com
| |