Messages in this thread | | | From | Doug Anderson <> | Date | Fri, 3 Nov 2023 09:02:02 -0700 | Subject | Re: [PATCH v2 1/4] drm/panel-edp: Add several AUO/BOE panels |
| |
Hi,
On Thu, Nov 2, 2023 at 3:13 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > Add a few generic edp panels used by mt8186 chromebooks. > Besides, modify the following panel: > - AUO 0x235c B116XTN02 renamed to B116XTN02.3. > - AUO 0x405c B116XAK01 adjust the timing of auo_b116xak01. According > to the datasheet: T3=200, T12=500, T7_max = 50. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > v1->v2: Address comments: update delay for auo_b116xak01, sort entries. > --- > drivers/gpu/drm/panel/panel-edp.c | 57 +++++++++++++++++++++++++++++-- > 1 file changed, 55 insertions(+), 2 deletions(-)
This seems good to me now. I guess a tiny nit is that the ${SUBJECT} mentions AUO/BOE panels but a few other model panels are also added, but it's not a huge issue for me.
Normally I apply patches to this table near-instantly, but since it's Friday and this touches a lot of panels, I'll probably wait until sometime next week.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
| |