| Date | Thu, 30 Nov 2023 00:20:28 +0100 | From | Andi Shyti <> | Subject | Re: [PATCH v4 24/24] i2c: designware: Fix spelling and other issues in the comments |
| |
Hi Andy,
[...]
> @@ -210,12 +210,12 @@ static void psp_release_i2c_bus(void) > { > mutex_lock(&psp_i2c_access_mutex); > > - /* Return early if mailbox was malfunctional */ > + /* Return early if mailbox was malfunctioned */
has malfunctioned?
> if (psp_i2c_mbox_fail) > goto cleanup; > > /* > - * If we are last owner of PSP semaphore, need to release aribtration > + * If we are last owner of PSP semaphore, need to release arbitration > * via mailbox. > */
as we are at this, perhaps we can add some articles and pronouns to improve the grammar:
/* * If we are the last owner of the PSP semaphore, we need to release * arbitration via the mailbox */
Rest looks good.
Thanks, Andi
|