lkml.org 
[lkml]   [2023]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 24/24] i2c: designware: Fix spelling and other issues in the comments
Hi Andy,

[...]

> @@ -210,12 +210,12 @@ static void psp_release_i2c_bus(void)
> {
> mutex_lock(&psp_i2c_access_mutex);
>
> - /* Return early if mailbox was malfunctional */
> + /* Return early if mailbox was malfunctioned */

has malfunctioned?

> if (psp_i2c_mbox_fail)
> goto cleanup;
>
> /*
> - * If we are last owner of PSP semaphore, need to release aribtration
> + * If we are last owner of PSP semaphore, need to release arbitration
> * via mailbox.
> */

as we are at this, perhaps we can add some articles and pronouns
to improve the grammar:

/*
* If we are the last owner of the PSP semaphore, we need to release
* arbitration via the mailbox
*/

Rest looks good.

Thanks,
Andi

\
 
 \ /
  Last update: 2023-11-30 00:21    [W:0.362 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site