lkml.org 
[lkml]   [2023]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 12/24] i2c: designware: Drop return value from dw_i2c_of_configure()
    Date
    dw_i2c_of_configure() is called without checking of the returned
    value, hence just drop it by converting to void.

    Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
    Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
    Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    drivers/i2c/busses/i2c-designware-platdrv.c | 7 ++-----
    1 file changed, 2 insertions(+), 5 deletions(-)

    diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
    index 15f19ec20b33..7449f1b37ecf 100644
    --- a/drivers/i2c/busses/i2c-designware-platdrv.c
    +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
    @@ -110,7 +110,7 @@ static int mscc_twi_set_sda_hold_time(struct dw_i2c_dev *dev)
    return 0;
    }

    -static int dw_i2c_of_configure(struct platform_device *pdev)
    +static void dw_i2c_of_configure(struct platform_device *pdev)
    {
    struct dw_i2c_dev *dev = platform_get_drvdata(pdev);

    @@ -123,8 +123,6 @@ static int dw_i2c_of_configure(struct platform_device *pdev)
    default:
    break;
    }
    -
    - return 0;
    }
    #else
    static int bt1_i2c_request_regs(struct dw_i2c_dev *dev)
    @@ -132,9 +130,8 @@ static int bt1_i2c_request_regs(struct dw_i2c_dev *dev)
    return -ENODEV;
    }

    -static inline int dw_i2c_of_configure(struct platform_device *pdev)
    +static inline void dw_i2c_of_configure(struct platform_device *pdev)
    {
    - return -ENODEV;
    }
    #endif

    --
    2.43.0.rc1.1.gbec44491f096
    \
     
     \ /
      Last update: 2023-11-20 15:48    [W:4.303 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site