Messages in this thread | | | Date | Tue, 28 Nov 2023 15:25:43 +0200 (EET) | From | Ilpo Järvinen <> | Subject | Re: [PATCH 4/5] tty: srmcons: switch need_cr to bool |
| |
On Mon, 27 Nov 2023, Jiri Slaby (SUSE) wrote:
> 'need_cr' is a flag, so type it properly to be a 'bool'. Move the > declaration into the loop too. That ensures the variable is initialized > properly even if the code was moved somehow. > > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru> > Cc: Matt Turner <mattst88@gmail.com> > Cc: linux-alpha@vger.kernel.org > --- > arch/alpha/kernel/srmcons.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/arch/alpha/kernel/srmcons.c b/arch/alpha/kernel/srmcons.c > index 32bc098de7da..c6b821afbfd3 100644 > --- a/arch/alpha/kernel/srmcons.c > +++ b/arch/alpha/kernel/srmcons.c > @@ -94,17 +94,16 @@ srmcons_do_write(struct tty_port *port, const char *buf, int count) > static char str_cr[1] = "\r"; > size_t c; > srmcons_result result; > - int need_cr; > > while (count > 0) { > - need_cr = 0; > + bool need_cr = false; > /* > * Break it up into reasonable size chunks to allow a chance > * for input to get in > */ > for (c = 0; c < min_t(size_t, 128U, count) && !need_cr; c++) > if (buf[c] == '\n') > - need_cr = 1; > + need_cr = true; > > while (c > 0) { > result.as_long = callback_puts(0, buf, c); > @@ -122,7 +121,7 @@ srmcons_do_write(struct tty_port *port, const char *buf, int count) > while (need_cr) { > result.as_long = callback_puts(0, str_cr, 1); > if (result.bits.c > 0) > - need_cr = 0; > + need_cr = false; > } > } > } >
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
-- i.
| |