Messages in this thread | | | Date | Tue, 28 Nov 2023 15:25:30 +0200 (EET) | From | Ilpo Järvinen <> | Subject | Re: [PATCH 2/5] tty: srmcons: make srmcons_do_write() return void |
| |
On Mon, 27 Nov 2023, Jiri Slaby (SUSE) wrote:
> The return value of srmcons_do_write() is ignored as all characters are > pushed. So make srmcons_do_write() to return void. > > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru> > Cc: Matt Turner <mattst88@gmail.com> > Cc: linux-alpha@vger.kernel.org > --- > > Notes: > [v2] reordered so that it makes sense > > arch/alpha/kernel/srmcons.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/alpha/kernel/srmcons.c b/arch/alpha/kernel/srmcons.c > index b68c5af083cd..de896fa9829e 100644 > --- a/arch/alpha/kernel/srmcons.c > +++ b/arch/alpha/kernel/srmcons.c > @@ -88,7 +88,7 @@ srmcons_receive_chars(struct timer_list *t) > } > > /* called with callback_lock held */ > -static int > +static void > srmcons_do_write(struct tty_port *port, const char *buf, int count) > { > static char str_cr[1] = "\r"; > @@ -125,7 +125,6 @@ srmcons_do_write(struct tty_port *port, const char *buf, int count) > need_cr = 0; > } > } > - return count; > } > > static ssize_t >
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
-- i.
| |