Messages in this thread Patch in this message | | | From | Su Hui <> | Subject | [PATCH v3] misc: mei: client.c: fix problem of return '-EOVERFLOW' in mei_cl_write | Date | Tue, 28 Nov 2023 09:45:08 +0800 |
| |
Clang static analyzer complains that value stored to 'rets' is never read.Using 'goto err' to go to the error path and fix this problem.
Fixes: 8c8d964ce90f ("mei: move hbuf_depth from the mei device to the hw modules") Signed-off-by: Su Hui <suhui@nfschina.com> --- v3: - using 'goto err' rather than 'buf_len=-EOVERFLOW'.(Thanks to Sasha)
v2: - split v1 patch to different patches https://lore.kernel.org/all/20231120095523.178385-2-suhui@nfschina.com/
v1: https://lore.kernel.org/all/5c98fc07-36a9-92cc-f8d6-c4efdc0c34aa@nfschina.com/
drivers/misc/mei/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c index 7ea80779a0e2..0489bec4fded 100644 --- a/drivers/misc/mei/client.c +++ b/drivers/misc/mei/client.c @@ -2033,7 +2033,7 @@ ssize_t mei_cl_write(struct mei_cl *cl, struct mei_cl_cb *cb, unsigned long time hbuf_slots = mei_hbuf_empty_slots(dev); if (hbuf_slots < 0) { rets = -EOVERFLOW; - goto out; + goto err; } hbuf_len = mei_slots2data(hbuf_slots) & MEI_MSG_MAX_LEN_MASK; -- 2.30.2
| |