Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Thu, 23 Nov 2023 14:25:01 +0800 | Subject | Re: [PATCH v3 3/3] regulator: mt6358: Add output voltage fine tuning to variable LDOs |
| |
Hi Bret,
On Thu, Nov 16, 2023 at 12:52 AM Bret Joseph <bretjoseph@gmail.com> wrote: > > In mt6358-regulator.c > > static const struct regulator_ops mt6358_volt_table_ops = { > .list_voltage = regulator_list_voltage_pickable_linear_range, > .map_voltage = regulator_map_voltage_pickable_linear_range, > .set_voltage_sel = regulator_set_voltage_sel_pickable_regmap, > .get_voltage_sel = mt6358_get_buck_voltage_sel /*regulator_get_voltage_sel_pickable_regmap*/, > .set_voltage_time_sel = regulator_set_voltage_time_sel, > .enable = regulator_enable_regmap, > .disable = regulator_disable_regmap, > .is_enabled = regulator_is_enabled_regmap, > .get_status = mt6358_get_status, > }; > > the function [regulator_get_voltage_sel_pickable_regmap] causes a -EINVAL when registering > > vsim1 vusb vcamd vefuse vmch vcama1 vemc vmc vldo28 vsim2 > > using [mt6358_get_buck_voltage_sel] results in a successful probe
Sure it will probe, but any values you read back will be bogus.
Can you provide a dump of /sys/kernel/debug/regulator/regulator_summary and `grep ^1e..: /sys/kernel/debug/regmap/1000d000.pwrap/registers`, and also any relevant logs?
ChenYu
| |