Messages in this thread | | | From | Dan Carpenter <> | Date | Thu, 23 Nov 2023 09:10:25 +0300 | Subject | drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c:507 vchiq_ioc_await_completion() warn: inconsistent indenting |
| |
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9b6de136b5f0158c60844f85286a593cb70fb364 commit: 1d8915cf889932e085880f4bdbf7ae0f3d8605e5 staging: vc04: Convert vchiq_log_error() to use dynamic debug config: mips-randconfig-r081-20231121 (https://download.01.org/0day-ci/archive/20231123/202311230705.w4DPJjm0-lkp@intel.com/config) compiler: mips-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20231123/202311230705.w4DPJjm0-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Reported-by: Dan Carpenter <error27@gmail.com> | Closes: https://lore.kernel.org/r/202311230705.w4DPJjm0-lkp@intel.com/
smatch warnings: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c:507 vchiq_ioc_await_completion() warn: inconsistent indenting
vim +507 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
f05916281fd75db Ojaswin Mujoo 2021-07-21 496 header = completion->header; f05916281fd75db Ojaswin Mujoo 2021-07-21 497 if (header) { f05916281fd75db Ojaswin Mujoo 2021-07-21 498 void __user *msgbuf; f05916281fd75db Ojaswin Mujoo 2021-07-21 499 int msglen; f05916281fd75db Ojaswin Mujoo 2021-07-21 500 f05916281fd75db Ojaswin Mujoo 2021-07-21 501 msglen = header->size + sizeof(struct vchiq_header); f05916281fd75db Ojaswin Mujoo 2021-07-21 502 /* This must be a VCHIQ-style service */ f05916281fd75db Ojaswin Mujoo 2021-07-21 503 if (args->msgbufsize < msglen) { 1d8915cf889932e Umang Jain 2023-10-24 504 vchiq_log_error(service->state->dev, VCHIQ_ARM, f05916281fd75db Ojaswin Mujoo 2021-07-21 505 "header %pK: msgbufsize %x < msglen %x", f05916281fd75db Ojaswin Mujoo 2021-07-21 506 header, args->msgbufsize, msglen); f05916281fd75db Ojaswin Mujoo 2021-07-21 @507 WARN(1, "invalid message size\n");
WARN() is indented too far.
f05916281fd75db Ojaswin Mujoo 2021-07-21 508 if (ret == 0) f05916281fd75db Ojaswin Mujoo 2021-07-21 509 ret = -EMSGSIZE; f05916281fd75db Ojaswin Mujoo 2021-07-21 510 break; f05916281fd75db Ojaswin Mujoo 2021-07-21 511 } f05916281fd75db Ojaswin Mujoo 2021-07-21 512 if (msgbufcount <= 0) f05916281fd75db Ojaswin Mujoo 2021-07-21 513 /* Stall here for lack of a buffer for the message. */
-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
| |