Messages in this thread Patch in this message | | | From | Dinghao Liu <> | Subject | [PATCH] crypto: ccp - fix memleak in ccp_init_dm_workarea | Date | Thu, 23 Nov 2023 15:03:37 +0800 |
| |
When dma_map_single() fails, we should free wa->address to prevent potential memleak.
Fixes: 63b945091a07 ("crypto: ccp - CCP device driver and interface support") Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- drivers/crypto/ccp/ccp-ops.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c index aa4e1a500691..45552ae6347e 100644 --- a/drivers/crypto/ccp/ccp-ops.c +++ b/drivers/crypto/ccp/ccp-ops.c @@ -179,8 +179,10 @@ static int ccp_init_dm_workarea(struct ccp_dm_workarea *wa, wa->dma.address = dma_map_single(wa->dev, wa->address, len, dir); - if (dma_mapping_error(wa->dev, wa->dma.address)) + if (dma_mapping_error(wa->dev, wa->dma.address)) { + kfree(wa->address); return -ENOMEM; + } wa->dma.length = len; } -- 2.17.1
| |