Messages in this thread Patch in this message | | | From | Ghanshyam Agrawal <> | Subject | [PATCH V2] media: stk1160: Fixed high volume of stk1160_dbg messages | Date | Wed, 22 Nov 2023 21:43:04 +0530 |
| |
The function stk1160_dbg gets called too many times, which causes the output to get flooded with messages. Since stk1160_dbg uses printk, it is now replaced with dev_warn_ratelimited.
Suggested-by: Phillip Potter <phil@philpotter.co.uk> Signed-off-by: Ghanshyam Agrawal <ghanshyam1898@gmail.com> --- v2: Thanks for your suggestions Phillip. I have updated the TODO comment and used dev_warn_ratelimited for inclusion of kernel warning.
drivers/media/usb/stk1160/stk1160-video.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/stk1160/stk1160-video.c b/drivers/media/usb/stk1160/stk1160-video.c index f5b75f380c19..a8e0d352a68c 100644 --- a/drivers/media/usb/stk1160/stk1160-video.c +++ b/drivers/media/usb/stk1160/stk1160-video.c @@ -105,6 +105,16 @@ void stk1160_copy_video(struct stk1160 *dev, u8 *src, int len) u8 *dst = buf->mem; int remain; + /* + * TODO: These stk1160_dbg are very spammy! + * We should check why we are getting them. + * + * UPDATE: One of the reasons (the only one?) for getting these + * is incorrect standard (mismatch between expected and configured). + * So perhaps, we could add a counter for errors. When the counter + * reaches some value, we simply stop streaming. + */ + len -= 4; src += 4; @@ -140,7 +150,7 @@ void stk1160_copy_video(struct stk1160 *dev, u8 *src, int len) /* Let the bug hunt begin! sanity checks! */ if (lencopy < 0) { - printk_ratelimited("copy skipped: negative lencopy\n"); + dev_warn_ratelimited(dev, "copy skipped: negative lencopy\n"); return; } -- 2.25.1
| |