| Date | Wed, 22 Nov 2023 14:25:35 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v5 21/39] ata: pata_ep93xx: add device tree support |
| |
On Wed, Nov 22, 2023 at 11:59:59AM +0300, Nikita Shubin wrote: > - add OF ID match table > - drop platform DMA and filters > - change DMA setup to OF, so we can defer probe
...
> + drv_data->dma_rx_channel = dma_request_chan(dev, "rx"); > + if (IS_ERR(drv_data->dma_rx_channel)) { > + ret = PTR_ERR(drv_data->dma_rx_channel); > + return dev_err_probe(dev, ret, "rx DMA setup failed"); > + }
PTR_ERR_OR_ZERO() as suggested in another patch?
...
> + drv_data->dma_tx_channel = dma_request_chan(&pdev->dev, "tx"); > + if (IS_ERR(drv_data->dma_tx_channel)) { > + ret = PTR_ERR(drv_data->dma_tx_channel); > + dev_err_probe(dev, ret, "tx DMA setup failed"); > + goto fail_release_rx; > }
Ditto.
-- With Best Regards, Andy Shevchenko
|