| Date | Wed, 22 Nov 2023 13:53:51 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v5 05/39] power: reset: Add a driver for the ep93xx reset |
| |
On Wed, Nov 22, 2023 at 11:59:43AM +0300, Nikita Shubin wrote: > Implement the reset behaviour of the various EP93xx SoCS in drivers/power/reset. > > It used to be located in arch/arm/mach-ep93xx.
...
> +#include <linux/bits.h> > +#include <linux/delay.h> > +#include <linux/mfd/syscon.h> > +#include <linux/notifier.h>
> +#include <linux/of.h>
I believe I already had commented in one of the previous rounds that this cargo cult of adding of.h (esp. if it's used as a proxy) is not a good idea. Please, revisit _ALL_ (and I mean it) your patches for this kind of issues.
...
> +#include <linux/reboot.h> > + > +#include <linux/soc/cirrus/ep93xx.h>
You see, here is a blank line, so I suggest keep it in all your patches for consistency's sake.
-- With Best Regards, Andy Shevchenko
|