| Date | Thu, 2 Nov 2023 08:27:53 +0100 | Subject | Re: [PATCH v2 03/13] scsi: fnic: Add and improve log messages | From | Hannes Reinecke <> |
| |
On 10/27/23 20:02, Karan Tilak Kumar wrote: > Add link related log messages in fnic_fcs.c, > Improve log message in fnic_fcs.c, > Add log message in vnic_dev.c. > > Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com> > Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com> > Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com> > --- > drivers/scsi/fnic/fnic_fcs.c | 36 ++++++++++++++++++++++++------------ > drivers/scsi/fnic/vnic_dev.c | 4 ++++ > 2 files changed, 28 insertions(+), 12 deletions(-) > > diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c > index 55632c67a8f2..203ffec625a4 100644 > --- a/drivers/scsi/fnic/fnic_fcs.c > +++ b/drivers/scsi/fnic/fnic_fcs.c > @@ -64,8 +64,8 @@ void fnic_handle_link(struct work_struct *work) > new_port_speed); > if (old_port_speed != new_port_speed) > FNIC_MAIN_DBG(KERN_INFO, fnic->lport->host, > - "Current vnic speed set to : %llu\n", > - new_port_speed); > + "fnic<%d>: %s: %d: Current vnic speed set to: %llu\n", > + fnic->fnic_num, __func__, __LINE__, new_port_speed); > Please update FNIC_MAIN_DBG() to use the 'fnic' structure as an argument, then you don't have to prefix all messages with 'fnic<%d>'.
Cheers,
Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman
|