| Date | Sun, 19 Nov 2023 16:50:19 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH net-next 03/15] net: dsa: mt7530: store port 5 SGMII capability of MT7531 |
| |
On Sat, Nov 18, 2023 at 03:31:53PM +0300, Arınç ÜNAL wrote: > Introduce the p5_sgmii field to store the information for whether port 5 > has got SGMII or not. Instead of reading the MT7531_TOP_SIG_SR register > multiple times, the register will be read once and the value will be > stored on the p5_sgmii field. This saves unnecessary reads of the > register. > > Move the comment about MT7531AE and MT7531BE to mt7531_setup(), where the > switch is identified. > > Get rid of mt7531_dual_sgmii_supported() now that priv->p5_sgmii stores the > information. Address the code where mt7531_dual_sgmii_supported() is used. > > Get rid of mt7531_is_rgmii_port() which just prints the opposite of > priv->p5_sgmii. > > Instead of calling mt7531_pll_setup() then returning, do not call it if > port 5 is SGMII. > > Remove P5_INTF_SEL_GMAC5_SGMII. The p5_interface_select enum is supposed to > represent the mode that port 5 is being used in, not the hardware > information of port 5. Set p5_intf_sel to P5_INTF_SEL_GMAC5 instead, if > port 5 is not dsa_is_unused_port(). > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Acked-by: Daniel Golle <daniel@makrotopia.org> > ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
|