lkml.org 
[lkml]   [2023]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v11 05/13] net:ethernet:realtek:rtase: Implement hardware configuration function
On Wed, 15 Nov 2023 21:34:06 +0800 Justin Lai wrote:
> + .ndo_vlan_rx_add_vid = rtase_vlan_rx_add_vid,
> + .ndo_vlan_rx_kill_vid = rtase_vlan_rx_kill_vid,
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> + .ndo_poll_controller = rtase_netpoll,
> +#endif
> + .ndo_setup_tc = rtase_setup_tc,

This patch is still way too huge. Please remove more functionality
from the initial version of the driver. You certainly don't need VLAN
support or CBS offload to pass packets.

\
 
 \ /
  Last update: 2023-11-20 14:04    [W:0.212 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site