Messages in this thread | | | From | Justin Lai <> | Subject | RE: [PATCH net-next v11 09/13] net:ethernet:realtek:rtase: Implement pci_driver suspend and resume function | Date | Tue, 21 Nov 2023 09:30:51 +0000 |
| |
> On 15.11.2023 14:34, Justin Lai wrote: > > Implement the pci_driver suspend function to enable the device to > > sleep, and implement the resume function to enable the device to > > resume operation. > > > > Signed-off-by: Justin Lai <justinlai0215@realtek.com> > > --- > > .../net/ethernet/realtek/rtase/rtase_main.c | 64 +++++++++++++++++++ > > 1 file changed, 64 insertions(+) > > > > diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c > > b/drivers/net/ethernet/realtek/rtase/rtase_main.c > > index 12607663dd72..b7679b74cc8a 100644 > > --- a/drivers/net/ethernet/realtek/rtase/rtase_main.c > > +++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c > > @@ -2323,12 +2323,76 @@ static void rtase_shutdown(struct pci_dev > *pdev) > > rtase_reset_interrupt(pdev, tp); } > > > > +#ifdef CONFIG_PM > > +static int rtase_suspend(struct pci_dev *pdev, pm_message_t state) { > > + struct net_device *dev = pci_get_drvdata(pdev); > > + > > + if (!netif_running(dev)) > > + goto out; > > + > > + netif_stop_queue(dev); > > + netif_carrier_off(dev); > > + netif_device_detach(dev); > > + rtase_hw_reset(dev); > > + > > +out: > > + pci_save_state(pdev); > > + > > + return 0; > > +} > > + > > +static int rtase_resume(struct pci_dev *pdev) { > > + struct net_device *dev = pci_get_drvdata(pdev); > > + struct rtase_private *tp = netdev_priv(dev); > > + int ret; > > + > > + pci_set_power_state(pdev, PCI_D0); > > + pci_restore_state(pdev); > > + pci_enable_wake(pdev, PCI_D0, 0); > > + > > IMO this is done by the PCI core already. See other drivers and PCI core code.
Thank you, I will check this part. > > > + /* restore last modified mac address */ > > + rtase_rar_set(tp, dev->dev_addr); > > + > > + if (!netif_running(dev)) > > + goto out; > > + > > + rtase_wait_for_quiescence(dev); > > + > > + rtase_tx_clear(tp); > > + rtase_rx_clear(tp); > > + > > + ret = rtase_init_ring(dev); > > + if (ret) { > > + netdev_err(dev, "unable to init ring\n"); > > + rtase_free_desc(tp); > > + return -ENOMEM; > > + } > > + > > + rtase_hw_config(dev); > > + /* always link, so start to transmit & receive */ > > + rtase_hw_start(dev); > > + > > + netif_carrier_on(dev); > > + netif_wake_queue(dev); > > + netif_device_attach(dev); > > + > > +out: > > + return 0; > > +} > > +#endif /* CONFIG_PM */ > > + > > static struct pci_driver rtase_pci_driver = { > > .name = KBUILD_MODNAME, > > .id_table = rtase_pci_tbl, > > .probe = rtase_init_one, > > .remove = rtase_remove_one, > > .shutdown = rtase_shutdown, > > +#ifdef CONFIG_PM > > + .suspend = rtase_suspend, > > + .resume = rtase_resume, > > Use pm_sleep_ptr and related macros then you don't need the conditional > compiling.
Thanks for your suggestion, I will modify this driver. > > > +#endif > > }; > > > > module_pci_driver(rtase_pci_driver);
| |