lkml.org 
[lkml]   [2023]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v3] sched/core: fix incorrect cpustat[CPUTIME_FORCEIDLE] update
Date
In function __account_forceidle_time(), task_group_account_field()
is called to update kernel_cpustat.cpustat[CPUTIME_FORCEIDLE].
However, p may be not running on current cpu, so update cpustat with
this_cpu_add() is incorrect.

To fix this problem, we get the cpu of p first, and then add delta
to kcpustat_cpu(cpu).cpustat[CPUTIME_FORCEIDLE].

Fixes: 1fcf54deb767 ("sched/core: add forced idle accounting for cgroups")
Signed-off-by: Cruz Zhao <CruzZhao@linux.alibaba.com>
---
kernel/sched/cputime.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
index af7952f12e6c..8e6d9bf351c2 100644
--- a/kernel/sched/cputime.c
+++ b/kernel/sched/cputime.c
@@ -239,9 +239,12 @@ void account_idle_time(u64 cputime)
*/
void __account_forceidle_time(struct task_struct *p, u64 delta)
{
+ unsigned int cpu = task_cpu(p);
+
__schedstat_add(p->stats.core_forceidle_sum, delta);

- task_group_account_field(p, CPUTIME_FORCEIDLE, delta);
+ kcpustat_cpu(cpu).cpustat[CPUTIME_FORCEIDLE] += delta;
+ cgroup_account_cputime_field(p, CPUTIME_FORCEIDLE, delta);
}
#endif

--
2.39.3
\
 
 \ /
  Last update: 2023-11-20 14:04    [W:0.036 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site