Messages in this thread | | | From | Javier Martinez Canillas <> | Subject | Re: [PATCH] drm/ili9163: Add "1.8-128160EF" to spi_device_id table | Date | Fri, 17 Nov 2023 09:03:51 +0100 |
| |
Mostafa Weshahy <mweshahy@yahoo.com> writes:
Hello Mostafa,
> drm/ili9163: Add "1.8-128160EF" to spi_device_id table > > Currently enabling CONFIG_TINYDRM_ILI9163 driver - regardless of the device > tree - results in the below confusing log line: > SPI driver ili9163 has no spi_device_id for newhaven,1.8-128160EF > > This commit fixes this false alarm by adding "1.8-128160EF" to > spi_device_id table of ili9163 driver. >
It's not actually a false alarm, this is needed if you want the driver module to be automatically loaded. Because the SPI core always reports a MODALIAS of the form "spi:1.8-128160EF" even if the device has been registered by OF.
So this is an actual fix since this driver can be built as a module.
> Signed-off-by: Mostafa Weshahy <mweshahy@yahoo.com> > ---
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
-- Best regards,
Javier Martinez Canillas Core Platforms Red Hat
| |