lkml.org 
[lkml]   [2023]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] PCI/ASPM: Add locked helper for enabling link state
On Fri, Nov 17, 2023 at 11:30:39AM +0100, Johan Hovold wrote:
> On Fri, Nov 17, 2023 at 03:57:24PM +0530, Manivannan Sadhasivam wrote:
> > On Wed, Nov 15, 2023 at 05:06:23PM +0100, Johan Hovold wrote:
> > > On Wed, Nov 15, 2023 at 10:26:40PM +0800, kernel test robot wrote:
> > >
> > > > >> drivers/pci/pcie/aspm.c:1186: warning: expecting prototype for pci_enable_link_state(). Prototype was for pci_enable_link_state_locked() instead
> > > >
> > > >
> > > > vim +1186 drivers/pci/pcie/aspm.c
> > > >
> > > > 1172
> > > > 1173 /**
> > > > 1174 * pci_enable_link_state - Clear and set the default device link state so that
> > >
> > > I apparently forgot to update the name here to
> > >
> > > pci_enable_link_state_locked
> > >
> >
> > While fixing the name, please add locking information in description as well.
>
> It's already there:
>
> Context: Caller holds pci_bus_sem read lock.

Ah, I was looking for it in the description. Fine then!

- Mani

>
> Johan

--
மணிவண்ணன் சதாசிவம்

\
 
 \ /
  Last update: 2023-11-20 14:02    [W:0.098 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site