lkml.org 
[lkml]   [2023]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] PCI/ASPM: Add locked helper for enabling link state
On Wed, Nov 15, 2023 at 05:06:23PM +0100, Johan Hovold wrote:
> On Wed, Nov 15, 2023 at 10:26:40PM +0800, kernel test robot wrote:
>
> > >> drivers/pci/pcie/aspm.c:1186: warning: expecting prototype for pci_enable_link_state(). Prototype was for pci_enable_link_state_locked() instead
> >
> >
> > vim +1186 drivers/pci/pcie/aspm.c
> >
> > 1172
> > 1173 /**
> > 1174 * pci_enable_link_state - Clear and set the default device link state so that
>
> I apparently forgot to update the name here to
>
> pci_enable_link_state_locked
>

While fixing the name, please add locking information in description as well.

- Mani

> [ ... ]
>
> > 1184 */
> > 1185 int pci_enable_link_state_locked(struct pci_dev *pdev, int state)
>
> Perhaps this can be fixed up when applying, or otherwise I'll respin.
>
> Johan

--
மணிவண்ணன் சதாசிவம்

\
 
 \ /
  Last update: 2023-11-20 14:02    [W:0.086 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site