Messages in this thread | | | Date | Mon, 13 Nov 2023 20:13:29 +0100 | Subject | Re: [PATCH] PCI: kirin: Use devm_kasprintf() | From | Christophe JAILLET <> |
| |
Le 13/11/2023 à 10:55, Krzysztof Wilczyński a écrit : > Hello! > > [...] >> @@ -387,9 +386,8 @@ static int kirin_pcie_get_gpio_enable(struct kirin_pcie *pcie, >> if (pcie->gpio_id_clkreq[i] < 0) >> return pcie->gpio_id_clkreq[i]; >> >> - sprintf(name, "pcie_clkreq_%d", i); >> - pcie->clkreq_names[i] = devm_kstrdup_const(dev, name, >> - GFP_KERNEL); >> + pcie->clkreq_names[i] = devm_kasprintf(dev, GFP_KERNEL, >> + "pcie_clkreq_%d", i); > > I think, the kirin_pcie_parse_port(), which is just below form this > function, might benefit from the same type of a nice change. Thoughts? > > Krzysztof >
Argh, yes, I've not seen it.
I'll send a v2 with both. Thx for seeing it.
CJ
| |