Messages in this thread | | | Date | Mon, 13 Nov 2023 18:55:57 +0900 | From | Krzysztof Wilczyński <> | Subject | Re: [PATCH] PCI: kirin: Use devm_kasprintf() |
| |
Hello!
[...] > @@ -387,9 +386,8 @@ static int kirin_pcie_get_gpio_enable(struct kirin_pcie *pcie, > if (pcie->gpio_id_clkreq[i] < 0) > return pcie->gpio_id_clkreq[i]; > > - sprintf(name, "pcie_clkreq_%d", i); > - pcie->clkreq_names[i] = devm_kstrdup_const(dev, name, > - GFP_KERNEL); > + pcie->clkreq_names[i] = devm_kasprintf(dev, GFP_KERNEL, > + "pcie_clkreq_%d", i);
I think, the kirin_pcie_parse_port(), which is just below form this function, might benefit from the same type of a nice change. Thoughts?
Krzysztof
| |