Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH wireless-next] wlcore: debugfs: add an error code check in beacon_filtering_write | Date | Mon, 13 Nov 2023 14:07:43 +0200 |
| |
Su Hui <suhui@nfschina.com> writes:
> On 2023/11/13 14:16, Kalle Valo wrote: > >> Su Hui <suhui@nfschina.com> writes: >> >>> wl1271_acx_beacon_filter_opt() return error code if failed, add a check >>> for this is better and safer. >>> >>> Signed-off-by: Su Hui <suhui@nfschina.com> >> How did you test this? > > Only compile test.
If you have only compile tested please document that clearly in the commit message.
> Clang static checker complains about this code that value stored to > 'ret' is never read.
This would be good to also have in the commit message.
> And most of the caller check the error code of > wl1271_acx_beacon_filter_opt().
This might still break something so I would prefer to test this in a real device before taking it.
-- https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |