Messages in this thread | | | Date | Mon, 13 Nov 2023 14:53:28 +0800 | Subject | Re: [PATCH wireless-next] wlcore: debugfs: add an error code check in beacon_filtering_write | From | Su Hui <> |
| |
On 2023/11/13 14:16, Kalle Valo wrote:
> Su Hui <suhui@nfschina.com> writes: > >> wl1271_acx_beacon_filter_opt() return error code if failed, add a check >> for this is better and safer. >> >> Signed-off-by: Su Hui <suhui@nfschina.com> > How did you test this? > Hi,
Only compile test. Clang static checker complains about this code that value stored to 'ret' is never read. And most of the caller check the error code of wl1271_acx_beacon_filter_opt().
Such like this: -- drivers/net/wireless/ti/wlcore/init.c:277: ret = wl1271_acx_beacon_filter_opt(wl, wlvif, false); drivers/net/wireless/ti/wlcore/init.c-278- if (ret < 0) drivers/net/wireless/ti/wlcore/init.c-279- return ret; -- drivers/net/wireless/ti/wlcore/init.c:410: ret = wl1271_acx_beacon_filter_opt(wl, wlvif, false); drivers/net/wireless/ti/wlcore/init.c-411- if (ret < 0) drivers/net/wireless/ti/wlcore/init.c-412- return ret; -- drivers/net/wireless/ti/wlcore/main.c:1652: ret = wl1271_acx_beacon_filter_opt(wl, wlvif, true); drivers/net/wireless/ti/wlcore/main.c-1653- if (ret < 0) drivers/net/wireless/ti/wlcore/main.c-1654- goto out;
Sorry for the few test.
Su Hui
| |