Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [PATCH] x86/resctrl: Fix unused variable warning in cache_alloc_hsw_probe() | Date | Wed, 1 Nov 2023 20:33:48 +0000 |
| |
> > if (wrmsr_safe(MSR_IA32_L3_CBM_BASE, max_cbm, 0)) > > return; > > > > - rdmsr(MSR_IA32_L3_CBM_BASE, l, h); > > + rdmsrl(MSR_IA32_L3_CBM_BASE, l3_cbm_0); > > You are writing 32 bit and reading 64 bit. Why don't you change both to 64 > bit?
wrmsr_safe() writes all 64-bits ... just gets those bits as a pair of 32-bit arguments for the low and high halves.
I could switch that to wrmsrl_safe() and change max_cbm to be "u64" to make write & read match. Would that be better?
-Tony
| |