Messages in this thread Patch in this message | | | From | Chen Ni <> | Subject | [PATCH v2] mfd: intel-lpss: Fix IRQ check | Date | Wed, 1 Nov 2023 06:26:43 +0000 |
| |
platform_get_irq() returns a negative error code to indicating an error. So in intel_lpss_probe() the unset / erroneous IRQ should be returned as is.
Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices") Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- Changelog:
v1 -> v2: 1. Update commit message 2. Fix IRQ check in intel_lpcc_probe() --- drivers/mfd/intel-lpss.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c index 9591b354072a..4c9d0222751a 100644 --- a/drivers/mfd/intel-lpss.c +++ b/drivers/mfd/intel-lpss.c @@ -378,9 +378,12 @@ int intel_lpss_probe(struct device *dev, struct intel_lpss *lpss; int ret; - if (!info || !info->mem || info->irq <= 0) + if (!info || !info->mem) return -EINVAL; + if (info->irq < 0) + return info->irq; + lpss = devm_kzalloc(dev, sizeof(*lpss), GFP_KERNEL); if (!lpss) return -ENOMEM; -- 2.25.1
| |