lkml.org 
[lkml]   [2023]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] tty: hso: Fix potential null pointer dereference
Date
Generally, the old always points to the address of a ktermios structure,
so old is unlikely to be NULL. Still check it before dereference as
elsewhere.

Signed-off-by: Ren Mingshuai <renmingshuai@huawei.com>
---
drivers/net/usb/hso.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index ce1f6081d582..4ad829ab54d3 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -1396,7 +1396,8 @@ static void hso_serial_set_termios(struct tty_struct *tty,
if (serial->port.count)
_hso_serial_set_termios(tty);
else
- tty->termios = *old;
+ if (old)
+ tty->termios = *old;
spin_unlock_irqrestore(&serial->serial_lock, flags);

/* done */
--
2.33.0
\
 
 \ /
  Last update: 2023-11-01 14:36    [W:0.146 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site