Messages in this thread Patch in this message | | | From | zhailiansen <> | Subject | [PATCH] netclassid: on modifying netclassid, only consider the main process. | Date | Sun, 8 Oct 2023 11:04:42 +0800 |
| |
When modifying netclassid, the command("echo 0x100001 > net_cls.classid") will take more time on muti threads of one process, because the process create many fds. for example, one process exists 28000 fds and 60000 threads, echo command will task 45 seconds. Now, we only consider the main process when exec "iterate_fd", and the time is 52 milliseconds.
Signed-off-by: zhailiansen <zhailiansen@kuaishou.com> --- net/core/netclassid_cgroup.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/net/core/netclassid_cgroup.c b/net/core/netclassid_cgroup.c index d6a70ae..78c903c 100644 --- a/net/core/netclassid_cgroup.c +++ b/net/core/netclassid_cgroup.c @@ -88,6 +88,12 @@ static void update_classid_task(struct task_struct *p, u32 classid) }; unsigned int fd = 0; + /* Only update the leader task, when multi threads in this task, + * so it can avoid the useless traversal. + */ + if (p && p != p->group_leader) + return; + do { task_lock(p); fd = iterate_fd(p->files, fd, update_classid_sock, &ctx); -- 1.8.3.1
| |