Messages in this thread Patch in this message | | | From | Randy Dunlap <> | Subject | [RFC PATCH] ssb: relax SSB_EMBEDDED dependencies | Date | Sat, 7 Oct 2023 11:24:43 -0700 |
| |
This is a kconfig warning in a randconfig when CONFIG_PCI is not set:
WARNING: unmet direct dependencies detected for SSB_EMBEDDED Depends on [n]: SSB [=y] && SSB_DRIVER_MIPS [=y] && SSB_PCICORE_HOSTMODE [=n] Selected by [y]: - BCM47XX_SSB [=y] && BCM47XX [=y]
This is caused by arch/mips/bcm47xx/Kconfig's symbol BCM47XX_SSB selecting SSB_EMBEDDED when CONFIG_PCI is not set.
This warning can be prevented by having SSB_EMBEDDED not depend on SSB_PCICORE_HOSTMODE, although some parts of SSB use PCI.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Michael Buesch <m@bues.ch> Cc: linux-wireless@vger.kernel.org --- Comments, thoughts?
I also tried changing arch/mips/bcm47xx/Kconfig's BCM47XX_SSB to select SSB_EMBEDDED if PCI but that results in build errors.
drivers/ssb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff -- a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig --- a/drivers/ssb/Kconfig +++ b/drivers/ssb/Kconfig @@ -134,7 +134,7 @@ config SSB_SFLASH # Assumption: We are on embedded, if we compile the MIPS core. config SSB_EMBEDDED bool - depends on SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE + depends on SSB_DRIVER_MIPS default y config SSB_DRIVER_EXTIF
| |