Messages in this thread | | | Date | Thu, 5 Oct 2023 07:44:30 +0900 | Subject | Re: [PATCH 2/4] ata: pata_parport: implement set_devctl | From | Damien Le Moal <> |
| |
On 10/5/23 03:52, Ondrej Zary wrote: > Add missing ops->sff_set_devctl implementation. > > Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)")
Missing "Cc: stable@vger.kernel.org" here. Same comment for patch 1. Otherwise, looks OK.
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> > Signed-off-by: Ondrej Zary <linux@zary.sk> > --- > drivers/ata/pata_parport/pata_parport.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c > index 258d189f42e5..cf87bbb52f1f 100644 > --- a/drivers/ata/pata_parport/pata_parport.c > +++ b/drivers/ata/pata_parport/pata_parport.c > @@ -51,6 +51,13 @@ static void pata_parport_dev_select(struct ata_port *ap, unsigned int device) > ata_sff_pause(ap); > } > > +static void pata_parport_set_devctl(struct ata_port *ap, u8 ctl) > +{ > + struct pi_adapter *pi = ap->host->private_data; > + > + pi->proto->write_regr(pi, 1, 6, ctl); > +} > + > static bool pata_parport_devchk(struct ata_port *ap, unsigned int device) > { > struct pi_adapter *pi = ap->host->private_data; > @@ -252,6 +259,7 @@ static struct ata_port_operations pata_parport_port_ops = { > .hardreset = NULL, > > .sff_dev_select = pata_parport_dev_select, > + .sff_set_devctl = pata_parport_set_devctl, > .sff_check_status = pata_parport_check_status, > .sff_check_altstatus = pata_parport_check_altstatus, > .sff_tf_load = pata_parport_tf_load,
-- Damien Le Moal Western Digital Research
| |