lkml.org 
[lkml]   [2023]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/4] ata: pata_parport: fix pata_parport_devchk
    Date
    There's a 'x' missing in 0x55 in pata_parport_devchk(), causing the
    detection to always fail. Fix it.

    Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)")
    Signed-off-by: Ondrej Zary <linux@zary.sk>
    ---
    drivers/ata/pata_parport/pata_parport.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c
    index 1af64d435d3c..258d189f42e5 100644
    --- a/drivers/ata/pata_parport/pata_parport.c
    +++ b/drivers/ata/pata_parport/pata_parport.c
    @@ -64,7 +64,7 @@ static bool pata_parport_devchk(struct ata_port *ap, unsigned int device)
    pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0xaa);
    pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0x55);

    - pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 055);
    + pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0x55);
    pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0xaa);

    nsect = pi->proto->read_regr(pi, 0, ATA_REG_NSECT);
    --
    Ondrej Zary
    \
     
     \ /
      Last update: 2023-10-04 20:54    [W:3.516 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site