Messages in this thread | | | Date | Tue, 31 Oct 2023 15:21:20 +0700 | From | Bagas Sanjaya <> | Subject | Fwd: Regression: Kernel 6.4 rc1 and higher causes Steam Deck to fail to wake from suspend (bisected) |
| |
Hi,
I notice a regression report on Bugzilla [1]. Quoting from it:
> On Kernel 6.4 rc1 and higher if you put the Steam Deck into suspend then press the power button again it will not wake up. > > I don't have a clue as to -why- this commit breaks wake from suspend on steam deck, but it does. Bisected to: > > ``` > 1ad11eafc63ac16e667853bee4273879226d2d1b is the first bad commit > commit 1ad11eafc63ac16e667853bee4273879226d2d1b > Author: Bjorn Helgaas <bhelgaas@google.com> > Date: Tue Mar 7 14:32:43 2023 -0600 > > nvme-pci: drop redundant pci_enable_pcie_error_reporting() > > pci_enable_pcie_error_reporting() enables the device to send ERR_* > Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is > native"), the PCI core does this for all devices during enumeration, so the > driver doesn't need to do it itself. > > Remove the redundant pci_enable_pcie_error_reporting() call from the > driver. Also remove the corresponding pci_disable_pcie_error_reporting() > from the driver .remove() path. > > Note that this only controls ERR_* Messages from the device. An ERR_* > Message may cause the Root Port to generate an interrupt, depending on the > AER Root Error Command register managed by the AER service driver. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> > Signed-off-by: Christoph Hellwig <hch@lst.de> > > drivers/nvme/host/pci.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > ``` > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-6.4.y&id=1ad11eafc63ac16e667853bee4273879226d2d1b > > Reverting that commit by itself on top of 6.5.9 (stable) allows it to wake from suspend properly.
See Bugzilla for the full thread.
Anyway, I'm adding this regression to regzbot:
#regression introduced: 1ad11eafc63ac1 https://bugzilla.kernel.org/show_bug.cgi?id=218090 #regression title: Steam Deck fails to wake from suspend due to pci_enable_pcie_error_reporting() removal
Thanks.
[1]: https://bugzilla.kernel.org/show_bug.cgi?id=218090
-- An old man doll... just what I always wanted! - Clara
| |