| Date | Mon, 30 Oct 2023 18:21:33 +0100 | Subject | Re: [PATCH v13 12/35] KVM: Prepare for handling only shared mappings in mmu_notifier events | From | Paolo Bonzini <> |
| |
On 10/27/23 20:21, Sean Christopherson wrote: > @@ -635,6 +635,13 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hva_range(struct kvm *kvm, > * the second or later invocation of the handler). > */ > gfn_range.arg = range->arg; > + > + /* > + * HVA-based notifications aren't relevant to private > + * mappings as they don't have a userspace mapping.
It's confusing who "they" is. Maybe
* HVA-based notifications provide a userspace address, * and as such are only relevant for shared mappings.
Paolo
> + */ > + gfn_range.only_private = false; > + gfn_range.only_shared = true; > gfn_range.may_block = range->may_block; > > /*
|