lkml.org 
[lkml]   [2023]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v13 21/35] KVM: Drop superfluous __KVM_VCPU_MULTIPLE_ADDRESS_SPACE macro
    On Fri, Oct 27, 2023 at 7:23 PM Sean Christopherson <seanjc@google.com> wrote:
    >
    > Drop __KVM_VCPU_MULTIPLE_ADDRESS_SPACE and instead check the value of
    > KVM_ADDRESS_SPACE_NUM.
    >
    > No functional change intended.
    >
    > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
    > Signed-off-by: Sean Christopherson <seanjc@google.com>
    > ---

    Reviewed-by: Fuad Tabba <tabba@google.com>
    Tested-by: Fuad Tabba <tabba@google.com>

    Cheers,
    /fuad

    > arch/x86/include/asm/kvm_host.h | 1 -
    > include/linux/kvm_host.h | 2 +-
    > 2 files changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
    > index 8d60e4745e8b..6702f795c862 100644
    > --- a/arch/x86/include/asm/kvm_host.h
    > +++ b/arch/x86/include/asm/kvm_host.h
    > @@ -2124,7 +2124,6 @@ enum {
    > #define HF_SMM_MASK (1 << 1)
    > #define HF_SMM_INSIDE_NMI_MASK (1 << 2)
    >
    > -# define __KVM_VCPU_MULTIPLE_ADDRESS_SPACE
    > # define KVM_ADDRESS_SPACE_NUM 2
    > # define kvm_arch_vcpu_memslots_id(vcpu) ((vcpu)->arch.hflags & HF_SMM_MASK ? 1 : 0)
    > # define kvm_memslots_for_spte_role(kvm, role) __kvm_memslots(kvm, (role).smm)
    > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
    > index e3223cafd7db..c3cfe08b1300 100644
    > --- a/include/linux/kvm_host.h
    > +++ b/include/linux/kvm_host.h
    > @@ -692,7 +692,7 @@ bool kvm_arch_irqchip_in_kernel(struct kvm *kvm);
    > #define KVM_MEM_SLOTS_NUM SHRT_MAX
    > #define KVM_USER_MEM_SLOTS (KVM_MEM_SLOTS_NUM - KVM_INTERNAL_MEM_SLOTS)
    >
    > -#ifndef __KVM_VCPU_MULTIPLE_ADDRESS_SPACE
    > +#if KVM_ADDRESS_SPACE_NUM == 1
    > static inline int kvm_arch_vcpu_memslots_id(struct kvm_vcpu *vcpu)
    > {
    > return 0;
    > --
    > 2.42.0.820.g83a721a137-goog
    >

    \
     
     \ /
      Last update: 2023-11-02 15:37    [W:8.132 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site