Messages in this thread | | | From | Stephan Mueller <> | Subject | Re: [PATCH 1/4] crypto: drbg - ensure most preferred type is FIPS health checked | Date | Mon, 30 Oct 2023 11:19:17 +0100 |
| |
Am Sonntag, 29. Oktober 2023, 21:48:20 CET schrieb Dimitri John Ledkov:
Hi Dimitri,
> drbg supports multiple types of drbg, and multiple parameters of > each. Health check sanity only checks one drbg of a single type. One > can enable all three types of drbg. And instead of checking the most > preferred algorithm (last one wins), it is currently checking first > one instead.
The purpose of the sanity check is to make sure the various thresholds are effective. For this, you need "a" DRBG, no matter which one. > > Update ifdef to ensure that healthcheck prefers HMAC, over HASH, over > CTR, last one wins, like all other code and functions.
I can see that this patch makes the code more consistent with the rest. Yet, I would doubt the "Fixes" indicator below is needed, though.
Anyhow:
Reviewed-by: Stephan Mueller <smueller@chronox.de>
Ciao Stephan
| |